[FFmpeg-devel] [PATCH] Add CPiA video decoder

[Carl Eugen Hoyos]

Stephan Hilb <stephan <at> ecshi.net> writes:

> --- a/doc/general.texi
> +++ b/doc/general.texi
> @@ -177,6 +177,7 @@ library:
>      @tab Amiga CD video format
>  @item Core Audio Format         @tab X @tab X
>      @tab Apple Core Audio Format
> + at item CPiA Video Format         @tab X @tab

This is the wrong block (decoders vs demuxers).

[...]

> +++ b/libavcodec/cpia.c
> @@ -0,0 +1,227 @@
> +/*
> + * CPiA video decoder.
> + * Copyright (c) 2012
> + *
> + * This file is part of FFmpeg.

This is missing "Copyright (c) 2010 Hans de Goede <hdegoede at redhat.com>"
and please understand that this is not a minor issue!
(And a sentence "This decoder is based on..." is 
probably also a good idea.)

[...]

> +typedef struct {
> +	// The frame we decode into

I don't think this is a useful comment.
(Many more to follow.)

> +    AVFrame frame;
> +} CpiaContext;

[...]

> +static av_cold int cpia_decode_end(AVCodecContext *avctx)
> +{
> +    return 0;
> +}

I suspect you can just remove this function.

[...]

> +        s1->video_codec_id = codec_id;

How does this work now for MJPEG?
(Or doesn't it work at all?)

As said, please use tools/patcheck, the git repository 
does not allow committing trailing whitespace and tabs.

Thank you, Carl Eugen