[FFmpeg-devel] [PATCH] lswr/swresample: use AV_OPT_TYPE_SAMPLE_FMT for sample format options

Stefano Sabatini stefasab at gmail.com
Sat Dec 1 00:13:18 CET 2012


On date Friday 2012-11-30 04:24:42 +0100, Michael Niedermayer encoded:
> On Fri, Nov 30, 2012 at 01:11:14AM +0100, Stefano Sabatini wrote:
> > Improve usability and robustness. This is technically an API/ABI break.
> 
> please elaborate why this is a API/ABI break, so i dont misunderstand
> the implications by mistake

With OPT_*_FMT I'm not setting min and max (are set to 0), so
opt.c:write_number() fails with an out-of-range.

I could set the range to [-1, FMT_NB-1] and fix it if you think it is
a good idea.
-- 
FFmpeg = Free and Forgiving Miracolous Powerful Enhanced Gadget


More information about the ffmpeg-devel mailing list