[FFmpeg-devel] [PATCH 2/2] iff demuxer: include DEEP TVDC lookup table in extradata buffer

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Dec 1 08:52:16 CET 2012


On Sat, Dec 01, 2012 at 05:41:31PM +1100, Peter Ross wrote:
> +            if ((res = avio_read(pb, iff->tvdc, sizeof(iff->tvdc))) < 0)

I guess I won't be able to convince you, but I can't stop myself
from say that munging this all into a single line IMHO is really
bad for readability, the assignment could just as well be in its own
line.

>  #include "libavutil/avutil.h"
>  
>  #define LIBAVFORMAT_VERSION_MAJOR 54
> -#define LIBAVFORMAT_VERSION_MINOR 41
> -#define LIBAVFORMAT_VERSION_MICRO 100
> +#define LIBAVFORMAT_VERSION_MINOR 42
> +#define LIBAVFORMAT_VERSION_MICRO 0

But my real comment is that the our micro version by policy starts at
100, to distinguish from Libav.


More information about the ffmpeg-devel mailing list