[FFmpeg-devel] [PATCH] lavu/parseutils: accept %h for hours >= 24.
michaelni at gmx.at
Sat Dec 1 17:23:59 CET 2012
On Sat, Dec 01, 2012 at 05:00:32PM +0100, Nicolas George wrote:
> Allow to parse durations >= 24:00:00.
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> libavutil/parseutils.c | 5 +++--
> libavutil/parseutils.h | 2 ++
> libavutil/version.h | 2 +-
> 3 files changed, 6 insertions(+), 3 deletions(-)
> This is the other suggested solution, but I must say I prefer the other one
> (adding an argument to the internal implementation of strptime) by far.
> Does anyone else have an opinion?
I prefer this patch here, our API is by a factor of about 2-3 too
complex we should reduce the number of non static functions IMHO
also the feature is usefull for other users of av_small_strptime
%h is already used, see:
man strptime says:
%b or %B or %h
The month name according to the current locale, in abbreviated form or the full name.
otherwise, LGTM and thanks
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Opposition brings concord. Out of discord comes the fairest harmony.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel