[FFmpeg-devel] [PATCH] lavf/vsrc: switch to ff_filter_frame.

Clément Bœsch ubitux at gmail.com
Sun Dec 2 00:27:08 CET 2012


On Sat, Dec 01, 2012 at 01:00:11PM +0100, Nicolas George wrote:
> Le primidi 11 frimaire, an CCXXI, Clément Bœsch a écrit :
> > Subject: [FFmpeg-devel] [PATCH] lavf/vsrc: switch to ff_filter_frame.
> 
> lavf -> lavfi
> 

Fixed

> > I just followed the change made to mandelbrot; I'm unsure about two things:
> >  - is it safe to remove the ref/unref?
> 
> I believe it is.
> 

I trust you then :)

> >  - should we raise the result of ff_filter_frame in these request_frame
> >    callbacks instead?
> 
> For that too, I believe so: errors in ff_filter_frame should happen only in
> bad circumstances, such as OOM.
> 

OK, will fix all of them in a row when we're done moving all the code to
ff_filter_frame.

> The patch looks right.
> 

Applied, thanks.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121202/2fba2d89/attachment.asc>


More information about the ffmpeg-devel mailing list