[FFmpeg-devel] [PATCH] lavfi/gradfun: fix direct writing in buffer.

Clément Bœsch ubitux at gmail.com
Sun Dec 2 04:29:33 CET 2012

On Sun, Dec 02, 2012 at 04:19:14AM +0100, Clément Bœsch wrote:
> ---
> This is an attempt to fix a few problems introduce recently:
>  - first, the use of AV_PERM_PRESERVE looks inappropriate, so we can remove it.
>  - then it seems assumed that gradfun can do filtering in-place (see the direct
>    flag). Though, that direct flag isn't passed to the filtering functions, and
>    the filter doesn't seem to assume/support dst=src, so we need to get a new
>    temporary buffer (allocated with ff_get_video_buffer) all the time.
>  - the out->video->w=outlink->w, out->video->h=outlink->h look uneeded since
>    avfilter_copy_buffer_ref_props handle this (and the filter doesn't change
>    the video size).
> Please comment,

Note: all of this seems to apply to hqdn3d as well…


Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121202/94ca6d61/attachment.asc>

More information about the ffmpeg-devel mailing list