[FFmpeg-devel] [PATCH] lavfi/blackdetect: switch to new shiny ff_filter_frame() API

[Stefano Sabatini]

On date Sunday 2012-12-02 02:43:47 +0100, Clément Bœsch encoded:
> On Sun, Dec 02, 2012 at 02:03:13AM +0100, Clément Bœsch wrote:
> [...]
> > >  static const AVFilterPad blackdetect_inputs[] = {
> > > @@ -202,10 +192,8 @@ static const AVFilterPad blackdetect_inputs[] = {
> > >          .name             = "default",
> > >          .type             = AVMEDIA_TYPE_VIDEO,
> > >          .config_props     = config_input,
> > > -        .draw_slice       = draw_slice,
> > >          .get_video_buffer = ff_null_get_video_buffer,
> > 
> > I think you can get rid of this one while at it.
> > 
> 

> Mmh, I may be mistaken actually. I wonder why it's not the default when
> NULL thought (and have ff_default_get_video_buffer only for sinks).

I think when it was designed, they guessed most filters would operate
on a separate buffer, so this was meant to simplify the code (I find
it a bit awkward as well).
-- 
FFmpeg = Formidable & Furious Minimalistic Plastic Ecstatic Generator