[FFmpeg-devel] [PATCH 3/3] Add assert that the avcodec lock isheld when initializing static VLC tables.

Clément Bœsch ubitux at gmail.com
Mon Dec 3 13:02:57 CET 2012


On Sun, Dec 02, 2012 at 06:55:30PM -0500, Don Moir wrote:
[...]
> av_assert0 calls av_log with the file and line number information.
> The problem with that is av_log is sometimes cluttered with hundreds
> and thousands of messages which are mostly useless outside of
> debugging and I turn this off rather than wasting time with BS. 

Even keeping only log level AV_LOG_FATAL?

> You pretty much never know where it came from and when you are running
> several videos in different threads at a time its a mixed bag.
> 

Your solution below doesn't solve this specific issue AFAICT.

> Would be good if rather than calling av_log in av_assert0 , the
> condition, file, and line number was passed back to the app via some
> other funtion rather than av_log which is not burdoned by crap.

Setting a av_log_callback and filtering only AV_LOG_FATAL wouldn't solve
your problem?

> This would also give a better oportunity for the app to log its own info
> with something meaningful and maybe get the problem fixed.

I don't understand this.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121203/3f8aa78b/attachment.asc>


More information about the ffmpeg-devel mailing list