[FFmpeg-devel] [PATCH 3/3] Add assert that the avcodec lock isheld when initializing static VLC tables.

Nicolas George nicolas.george at normalesup.org
Mon Dec 3 13:21:41 CET 2012


Le duodi 12 frimaire, an CCXXI, Don Moir a écrit :
> Do I need a bug report for this ?

If you get an assert failure, yes, you should submit a bug report.

> Would be good if rather than calling av_log in av_assert0 , the
> condition, file, and line number was passed back to the app

No. When an assert failure is reached, there is _nothing_ to do. An assert
failure means that some piece of code did something that it was not supposed
to do. At this point, the memory may be corrupted anywhere, and continuing
anything in the application is a risk of making things worse, and in
particular a possibility of security exploit. Even printing the file and
line is a risk.

Regards,

-- 
  Nicolas George


More information about the ffmpeg-devel mailing list