[FFmpeg-devel] [PATCH 2/5] lavfi/gradfun: fix rounding in MMX code.

Loren Merritt lorenm at u.washington.edu
Fri Dec 7 16:28:47 CET 2012

On Fri, 7 Dec 2012, Reimar Döffinger wrote:
> "Clément Bÿÿsch" <ubitux at gmail.com> wrote:
>> Current code divide before increasing precision.
> Are you sure the shift can _never_ overflow? It is definitely very tight.

I expect it can overflow, but the case where it does so also has m=0 for
sane filter strengths. So the appropriate fix would be to limit strength,
not change the asm.

--Loren Merritt

More information about the ffmpeg-devel mailing list