[FFmpeg-devel] [PATCH] lavfi: add aselect audio variant of select

Stefano Sabatini stefasab at gmail.com
Thu Dec 13 00:00:40 CET 2012


On date Wednesday 2012-12-12 21:31:04 +0100, Clément Bœsch encoded:
> On Tue, Dec 11, 2012 at 11:22:56PM +0100, Stefano Sabatini wrote:
> > TODO: add Changelog entry, bump minor
> > ---
> >  doc/filters.texi         |   20 +++++++--
> >  libavfilter/Makefile     |    1 +
> >  libavfilter/allfilters.c |    1 +
> >  libavfilter/vf_select.c  |  106 +++++++++++++++++++++++++++++++++++++---------
> >  4 files changed, 104 insertions(+), 24 deletions(-)
> > 
> > diff --git a/doc/filters.texi b/doc/filters.texi
> > index b840cac..fefc2af 100644
> > --- a/doc/filters.texi
> > +++ b/doc/filters.texi
> [...]
> > - at item scene
> > + at item scene @emph{(only video)}
> 
> nit++: "video only"? (and "audio only")

Changed.
 
> >  value between 0 and 1 to indicate a new scene; a low value reflects a low
> >  probability for the current frame to introduce a new scene, while a higher
> >  value means the current frame is more likely to be one (see the example below)
> > @@ -3617,6 +3626,9 @@ select='gte(t\,10)*lte(t\,20)*eq(pict_type\,I)'
> >  
> >  # select frames with a minimum distance of 10 seconds
> >  select='isnan(prev_selected_t)+gte(t-prev_selected_t\,10)'
> > +
> > +# use aselect to select only audio frames with samples number > 100
> > +aselect='gt(samples_n, 100)'
> 
> Please stick with the surrounding escaping until we decide what to do with
> them.

OK.
 
> [...]
> 
> The code LGTM.

Will push it soon, thanks guys for the review.
-- 
FFmpeg = Fascinating and Free Mournful Puristic Elfic Ghost


More information about the ffmpeg-devel mailing list