[FFmpeg-devel] [PATCH] brstm: Fix last packet samples calculation

Derek Buitenhuis derek.buitenhuis at gmail.com
Sun Dec 16 00:30:12 CET 2012

On 15/12/2012 6:21 PM, jamal wrote:
> Subject: [PATCH] brstm: Fix last packet samples calculation
> This fixes the calculation of samples in the last packet
> of non-stereo streams.
> Signed-off-by: James Almer <jamrial at gmail.com>

That's not really what I meant. That's pretty much:

    Fix bug

    This fixes bug when N is true.

An example, in this case, of what a good commit message could be is:

    brstm: Fix calculates of number of samples for the last block

    Previously, despite actually reading the number of channels from the file,
    we had hardcoded it to 2 during calculation of the remaining samples for
    the last block.

    Instead, use the number of channels we read in earlier to calculate it.

Patch itself looks OK.

- Derek

More information about the ffmpeg-devel mailing list