[FFmpeg-devel] [PATCH] thp: set duration
derek.buitenhuis at gmail.com
Mon Dec 17 22:56:19 CET 2012
On 17/12/2012 3:34 PM, Paul B Mahol wrote:
>> Excuse me?
>> You have pushed it whilst completely ignoring my reviews. You have not
>> even provided an explanation. This is incredibly rude and unprofessional.
>> I don't think this sort of behavior is acceptable in a collaborative
>> Perhaps you can expand on why?
> Many demuxers use number of frames in stream as stream duration.
> If you do not like current state post patch that address this by using
> nb_frames to set duration (similar how it is done for bitrate). This
> would also factorize some code.
It's all well and fine that the patch was technically correct (for reasons other
than you listed here, actually), but that does not make it OK to disregard others'
reviews entirely and apply things without explanation or even the courtesy to nte
why. That is -extremely- rude and unprofessional, and very counterproductive in
creating a collaborative environment for development.
More information about the ffmpeg-devel