[FFmpeg-devel] [PATCH] thp: set duration

Alexander Strasser eclipse7 at gmx.net
Mon Dec 17 23:01:03 CET 2012

Paul B Mahol wrote:
> On 12/16/12, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> > On 16/12/2012 6:35 AM, Paul B Mahol wrote:
> >> On 12/15/12, Piotr Bandurski <ami_stuff at o2.pl> wrote:
> >>> {no text body}
> >>
> >> applied
> >
> > Excuse me?
> >
> > You have pushed it whilst completely ignoring my reviews. You have not
> > even provided an explanation. This is incredibly rude and unprofessional.
> >
> > I don't think this sort of behavior is acceptable in a collaborative
> > environment.
> >
> > Perhaps you can expand on why?
> Many demuxers use number of frames in stream as stream duration.
> If you do not like current state post patch that address this by using
> nb_frames to set duration (similar how it is done for bitrate). This
> would also factorize some code.

  Please post explanations prior to pushing. In general we try to not
push patches that are still in discussion. There can be exceptions if
it is security related or the discussion peer suddenly disappeared but
neither was the case here AFAICT.

  Also note that I do not agree with the tone of Derek's response. But
I beg both of you to calm down now. We have been good at discussing
things peacefully, please everyone keep the discipline! (I know it sure
can be tough from time to time.)


More information about the ffmpeg-devel mailing list