[FFmpeg-devel] [PATCH] aiffenc: set correct number of bits foru8 in aiff

Michael Niedermayer michaelni at gmx.at
Thu Dec 20 16:08:33 CET 2012


On Wed, Dec 12, 2012 at 09:51:30PM +0100, Piotr Bandurski wrote:
> Hi,
> 
> > what if you just remove the 'enc->bits_per_coded_sample = 16;' line?
> > 
> > as further down the function there is:
> > 
> >  if (!enc->bits_per_coded_sample)
> >  enc->bits_per_coded_sample = av_get_bits_per_sample(enc->codec_id);
> > 
> > which should calculate the correct value.
> 
> Yes it fixes the problem as well, new patch attached.
> 
> Regards
> 

> diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c
> index 8cdb261..ba5f607 100644
> --- a/libavformat/aiffenc.c
> +++ b/libavformat/aiffenc.c
> @@ -53,7 +53,6 @@ static int aiff_write_header(AVFormatContext *s)
>      ffio_wfourcc(pb, aifc ? "AIFC" : "AIFF");
>  
>      if (aifc) { // compressed audio
> -        enc->bits_per_coded_sample = 16;
>          if (!enc->block_align) {

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121220/a3282b20/attachment.asc>


More information about the ffmpeg-devel mailing list