[FFmpeg-devel] [PATCH] vf_tinterlace: add vertical low-pass-filter option to mode 4 and 5

[Stefano Sabatini]

On date Saturday 2012-12-22 23:25:19 +0000, Mark Himsley encoded:
> On 22/12/2012 12:10, Stefano Sabatini wrote:
> > On date Friday 2012-12-21 12:58:07 +0000, Mark Himsley encoded:
> >> On 19/12/2012 17:17, Mark Himsley wrote:
> >>> Low-pass filtering is required when creating an interlaced destination
> >>> from a progressive source which contains high-frequency vertical detail.
> >>> Filtering will reduce interlace 'twitter' and Moire patterning.
> >>
> >> minor update to correct the consts.
> > 
> > Sorry for the slow reply.
> 
> I'm grateful for the review.
> 
> >> + * Other than low-pass filtering, this functions identicaly to
> >> + * copy_picture_field() above.
> > 
> > Note: would it make sense to move this to a separate filter?
> 
> I don't think so. I can't currently think of a use-case.
> Were this filter to be separate from tinterlace, to insert just before
> the tinterlace filter, then it would have to do twice as many
> calculations - it would calculate all the lines that were about to be
> dropped in the interleave interlace. I do not think that is a good idea.
> 
> Updated patch attached.
> 
> -- 
> Mark

> diff --git a/libavfilter/vf_tinterlace.c b/libavfilter/vf_tinterlace.c
> index 7161e67..aad38a8 100644
> --- a/libavfilter/vf_tinterlace.c
> +++ b/libavfilter/vf_tinterlace.c
> @@ -1,14 +1,16 @@
>  /*
> + * Copyright (c) 2011 Stefano Sabatini
> + * Copyright (c) 2010 Baptiste Coudurier
>   * Copyright (C) 2003 Michael Zucchi <notzed at ximian.com>
>   *
> - * This file is part of MPlayer.
> + * This file is part of FFmpeg.
>   *
> - * MPlayer is free software; you can redistribute it and/or modify
> + * FFmpeg is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
>   * the Free Software Foundation; either version 2 of the License, or
>   * (at your option) any later version.
>   *
> - * MPlayer is distributed in the hope that it will be useful,
> + * FFmpeg is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   * GNU General Public License for more details.
> @@ -18,202 +20,127 @@
>   * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>   */

Wrong patch?
-- 
FFmpeg = Forgiving and Fantastic Miracolous Political Epic Glue