[FFmpeg-devel] [PATCH 01/10] lavfi: add avfilter_get_audio_buffer_ref_from_arrays_nolayout.

Nicolas George nicolas.george at normalesup.org
Sun Dec 30 19:57:45 CET 2012

Le decadi 10 nivôse, an CCXXI, Stefano Sabatini a écrit :
> _arrays2() should be fine as well (and shorter), and "nolayout" is
> confusing (since layout *can* be specified).

I agree that nolayout is confusing, but if I go with _arrays2, there is a
big risk that someone (A.... K......?) will add a function with the same
name but a different semantic, and then we have big problems.

The function can not be made private either, because creating a buffer is
necessary to insert frames in lavfi with certain APIs.

> spurious

Locally fixed.

> av_log ERROR?

It is inside a deprecated and unused function, I would not bother with it,
unless you think it is really necessary.

Thanks for the review.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121230/388fb8ab/attachment.asc>

More information about the ffmpeg-devel mailing list