[FFmpeg-devel] [PATCH] web: add g+ badge that links to FFmpeg page on g+

Michael Niedermayer michaelni at gmx.at
Mon Dec 31 03:06:10 CET 2012


On Sun, Dec 30, 2012 at 10:22:54PM +0100, Alexander Strasser wrote:
> Lou Logan wrote:
> > On Sun, 30 Dec 2012 19:45:40 +0000, Paul B Mahol wrote:
> > 
> > > ---
> > >  src/index | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/src/index b/src/index
> > > index 72063c7..1f0084c 100644
> > > --- a/src/index
> > > +++ b/src/index
> > > @@ -31,7 +31,8 @@ with the latest developments by subscribing to both the
> > >  </p>
> > >  
> > >  
> > > -<h1>News <a href="main.rss"><img style="vertical-align: middle; margin-left: 6px" src="Feed-icon.png" alt="[RSS]" /></a></h1>
> > > +<h1>News <a href="main.rss"><img style="vertical-align: middle; margin-left: 6px" src="Feed-icon.png" alt="[RSS]" /></a><a href="https://plus.google.com/108003112428040046828?prsrc=3" rel="publisher" style="text-decoration:none;">
> > > +<img src="https://ssl.gstatic.com/images/icons/gplus-16.png" alt="Google+" style="vertical-align: middle; margin-left: 16px"/></a></h1>
> > 
> > nit: For consistency: '16px"; />'
> > Although don't waste your time with that unless others have suggestions.
> > 
> > I'm a social media hermit, and ignorant of g+, but technically LGTM
> > assuming you looked at it in-browser.
> > 
> > If we get more badge things I think a better place for non-news icons
> > would be on the far right side of "Project Description" as I mentioned
> > on IRC.
> 
>   I looked at it in-browser and W3C validation was also fine. So LGTM.

applied

thanks to all

PS: i also replaced the link to the g+ icon with a local copy.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121231/f896aa3b/attachment.asc>


More information about the ffmpeg-devel mailing list