[FFmpeg-devel] [PATCH 02/10] lavfi: support unknown channel layouts.

Stefano Sabatini stefasab at gmail.com
Mon Dec 31 10:44:52 CET 2012


On date Monday 2012-12-31 01:26:21 +0100, Nicolas George encoded:
> Le decadi 10 nivôse, an CCXXI, Stefano Sabatini a écrit :
> > What I mean: adding a specific field 
> > all_channel_layouts
> > to mean that all channel layouts are supported, and a field:
> > 
> > all_channel_counts
> > to mean that all channel counts (and layouts) are supported.
> > 
> > This should provide a more consistent semantic, and remove the
> > arbitrary mapping:
> > 
> > empty list -> all channel layouts
> > { CH_LAYOUT_UNKNOWN } -> all channel layouts and counts
> > 
> > which looks rather arbitrary to me. My supposition is that such fields
> > would make the code simpler/more readable.
> 

> Ah, I see. That may be true, I will have to try to write it that way.
> Unfortunately, it does not avoid the AV_CH_LAYOUT_UNKNOWN constant, for
> filters that want to specify they accept 2 channels, whatever
> layout.

What about:
all_channel_layouts + AV_CH_LAYOUT_UNKNOWN|2
?

> Other data structures could be possible, but nothing as simple as a
> flag.
-- 
FFmpeg = Faithless & Free Multipurpose Perfectionist Enhancing Governor


More information about the ffmpeg-devel mailing list