[FFmpeg-devel] [PATCH] ansi: Fix use of uninitalized width/height warning.

Paul B Mahol onemda at gmail.com
Mon Feb 6 02:49:42 CET 2012


On 2/6/12, Michael Niedermayer <michaelni at gmx.at> wrote:
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavcodec/ansi.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/libavcodec/ansi.c b/libavcodec/ansi.c
> index ebcc288..1128d6f 100644
> --- a/libavcodec/ansi.c
> +++ b/libavcodec/ansi.c
> @@ -182,6 +182,8 @@ static int execute_code(AVCodecContext * avctx, int c)
>      case 'l': //reset screen mode
>          if (s->nb_args < 2)
>              s->args[0] = DEFAULT_SCREEN_MODE;
> +        width = avctx->width;
> +        height = avctx->height;
>          switch(s->args[0]) {
>          case 0: case 1: case 4: case 5: case 13: case 19: //320x200 (25
> rows)
>              s->font = ff_cga_font;

I think that correct fix is to abort in case of unsupported screen mode.


More information about the ffmpeg-devel mailing list