[FFmpeg-devel] [PATCH 3/3] bink: remove unneeded special case in the init code.

[Peter Ross]

On Mon, Feb 06, 2012 at 08:50:47PM +0100, Michael Niedermayer wrote:
> On Mon, Feb 06, 2012 at 07:42:37PM +0100, Clément Bœsch wrote:
> > On Mon, Feb 06, 2012 at 07:31:05PM +0100, Michael Niedermayer wrote:
> > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > > ---
> > >  libavcodec/bink.c |    6 ------
> > >  1 files changed, 0 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/libavcodec/bink.c b/libavcodec/bink.c
> > > index c77c139..8adc473 100644
> > > --- a/libavcodec/bink.c
> > > +++ b/libavcodec/bink.c
> > > @@ -1258,12 +1258,6 @@ static av_cold void binkb_calc_quant(void)
> > >      for (j = 0; j < 16; j++) {
> > >          for (i = 0; i < 64; i++) {
> > >              int k = inv_bink_scan[i];
> > > -            if (s[i] == C) {
> > > -                binkb_intra_quant[j][k] = (1L << 12) * binkb_intra_seed[i] *
> > > -                                          binkb_num[j]/binkb_den[j];
> > > -                binkb_inter_quant[j][k] = (1L << 12) * binkb_inter_seed[i] *
> > > -                                          binkb_num[j]/binkb_den[j];
> > > -            } else {
> > >                  binkb_intra_quant[j][k] = binkb_intra_seed[i] * (int64_t)s[i] *
> > >                                            binkb_num[j]/(binkb_den[j] * (C>>12));
> > >                  binkb_inter_quant[j][k] = binkb_inter_seed[i] * (int64_t)s[i] *
> > > -- 
> > > 1.7.5.4
> > > 
> > 
> > Isn't the patch truncated? it looks like a closing '}' remove is missing
> > or something.
> 
> git add -p mistake ...
> 
> 
> > 
> > Also, stupid question: why is it unneeded?
> 
> it produces the same result as the generic case
> 
> 
> > 
> > (please reindent right away after such commit).
> 
> commit added locally

Looks good here.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120207/620928b9/attachment.asc>