[FFmpeg-devel] [PATCH 1/2] Modified to generate PAT/PMT on every video keyframe. This is so that TS fragments produced by http://code.google.com/p/httpsegmenter/ would be compatible with JW Player.
Reimar.Doeffinger at gmx.de
Fri Feb 10 20:29:45 CET 2012
On Fri, Feb 10, 2012 at 12:06:36PM -0700, pkoshevoy at gmail.com wrote:
Please format the commit message so that after a short summary
you have an empty line and then details.
The short summary should be preferably be max. 60 characters to
nicely fit into the email subject.
> @@ -788,10 +788,12 @@ static void mpegts_write_pes(AVFormatContext *s, AVStream *st,
> int afc_len, stuffing_len;
> int64_t pcr = -1; /* avoid warning */
> int64_t delay = av_rescale(s->max_delay, 90000, AV_TIME_BASE);
> + int force_pat = key && (st->codec->codec_type == AVMEDIA_TYPE_VIDEO);
The () are unnecessary.
I don't know enough about TS to comment much, except that this
is possibly a bit crazy for the intra-only use case.
> -8f61dad7652abbab9e49fca274dabf30 *./tests/data/lavf/lavf.ts
> -406644 ./tests/data/lavf/lavf.ts
> +34f95a300355d474767b436430eba15b *./tests/data/lavf/lavf.ts
> + 406644 ./tests/data/lavf/lavf.ts
Interesting that the file doesn't even get bigger in this case
More information about the ffmpeg-devel