[FFmpeg-devel] [PATCH] configure: add lavfi dependencies to .pc files.

[Nicolas George]

Le decadi 30 pluviôse, an CCXX, Alexander Strasser a écrit :
>   I just got around to read your patch more carefully.
> 
>   In general I think it is needed and it looks good to me with my
> limited knowledge of FFmpeg configure. Be aware that I didn't test
> it though.

Thanks.

>   The indentation looks messed though. Are there tabs in there?

Indeed, my vim hooks were only for C. Fixed.

>   Looks a bit weird at first but should be OK. If we will need
> this kind of lists at more places, it should be refactored.

That is true, but it can wait when we know we need it.

>   So if you feel comfortable with your changes and no one else
> comments soon, IMHO push.

I did just that.

There is still room for improvement in the .pc department though. For
example, if configured with --enable-libfreetype, then the "Libs:" field in
libavcodec.pc will have "-lfreetype" even though -lfreetype is only needed
for lavfi. Same for -lSDL, which is only needed by libavdevice, etc.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120223/4603c0c0/attachment.asc>