[FFmpeg-devel] 4xm idct computation

Michael Niedermayer michaelni at gmx.at
Tue Jan 3 04:32:08 CET 2012


On Thu, Dec 29, 2011 at 03:11:20AM +0100, yann.lepetitcorps at free.fr wrote:
> > > > Perhaps that the y*stride can to be factorised into the
> > > ff_snow_pred_block()
> > > > func because this was very redundant ?
> > > > (the same thing with the y*src_stride into ff_snow_inner_add_yblock() )
> 
> With this diff, the factorisation into ff_snow_pred_block() is really more
> apparent :)
> 
> 
> diff --git a/libavcodec/snow.c b/libavcodec/snow.c
> index 0ce9b28..5b256d4 100644
> --- a/libavcodec/snow.c
> +++ b/libavcodec/snow.c
> @@ -288,41 +288,31 @@ static void mc_block(Plane *p, uint8_t *dst, const uint8_t
> *src, int stride, int
>  }
> 
>  void ff_snow_pred_block(SnowContext *s, uint8_t *dst, uint8_t *tmp, int stride,
> int sx, int sy, int b_w, int b_h, BlockNode *block, int plane_index, int w, int
> h){

The patch is mangled, probably your mail user agent did word wrap it
to 80 chars

also what speed effect does the change have ?
is it faster ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120103/1f18b196/attachment.asc>


More information about the ffmpeg-devel mailing list