[FFmpeg-devel] [PATCH] Use an int MotionVector for find_block_motion.

Michael Niedermayer michaelni at gmx.at
Sat Jan 7 14:06:04 CET 2012

On Sat, Jan 07, 2012 at 12:20:38PM +0100, Reimar Döffinger wrote:
> Using the double variant causes several pointless conversions between
> double and int.
> Worse, one of the conversions is in an inner loop together with a
> function using MMX, resulting in undefined behaviour.
> In general the typedefs/structs seem overkill and slightly obfuscating
> to me, but I left that in the assumption that the author/maintainer
> prefers it.
> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>

LGTM but please mention  Ray Simard in the commit message for finding
and analyzing the bug 

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120107/8a4ce032/attachment.asc>

More information about the ffmpeg-devel mailing list