[FFmpeg-devel] [PATCH 1/2] libmp3lame: It appears the buffer used is a bit too small.

[Alexander Strasser]

Hi,

Michael Niedermayer wrote:
> On Sun, Jan 08, 2012 at 08:30:26PM +0000, Paul B Mahol wrote:
> > On 1/8/12, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > On Sun, Jan 08, 2012 at 07:46:56PM +0000, Paul B Mahol wrote:
> > >> On 1/8/12, Michael Niedermayer <michaelni at gmx.at> wrote:
> > >> > Increase it by an arbitrary amount.
> > >> > Fixes part of Ticket676
> > >> >
> > >> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > >> > ---
> > >> >  libavcodec/libmp3lame.c |    2 +-
> > >> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > >> >
> > >>
> > >> Add AVOption with sensible limitations and default value?
> > >
> > > the value should be made large enough to work in all cases,
> > > apparently the value that was there was too small or theres a bug
> > > elsewhere. I dont think making it user selectable is going to help
> > 
> > Yes, I agree.
> 
> so, ok if we apply this and see if it is large enough ?
> or is there some volunteer to investigate this further ?

  Unfortunately I am not volunteering to investigate, but please if
you apply the patch increasing the buffer size also add a comment.

  Quick suggestion:
  FIXME: Buffer size to small? Adding 1000 to make up for it.

  Else the next person reading it will wonder where the arbitrary
addition of 1000 comes from. Adding a fixme-comment also might
help to get someone to investigate who is reading that source
code.

  Alexander