[FFmpeg-devel] [PATCH] Avoid "it" ARM instruction in non-Thumb mode.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Jan 9 20:54:56 CET 2012


On Tue, Dec 20, 2011 at 01:45:43PM +0100, Michael Niedermayer wrote:
> On Sun, Dec 18, 2011 at 12:22:02PM +0100, Reimar Döffinger wrote:
> > This instruction only has an effect in Thumb2 mode and
> > some assemblers do not support this syntax.
> > The disadvantage is since we by default compile as ARM and
> > not Thumb none of the fate machines will check that the "it"
> > instruction encodes the same condition codes as the following
> > instructions.
> > 
> > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> 
> LGTM

Sorry, I forgot about this.
This is used in quite a few more places, so that patch on its
own won't fix anything.
No idea whether changing all would help, it might be worthwhile
to try if someone has the motivation (though it would be better
to us a macro instead of loads of ifdefs.


More information about the ffmpeg-devel mailing list