[FFmpeg-devel] [PATCH] sws: Move yuv2rgb cliping into the tables.

Michael Niedermayer michaelni at gmx.at
Tue Jan 10 21:19:50 CET 2012

On Tue, Jan 10, 2012 at 09:02:03PM +0100, Reimar Döffinger wrote:
> On Tue, Jan 10, 2012 at 08:57:29PM +0100, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libswscale/swscale.c          |   31 +++++++++++++++----------------
> >  libswscale/swscale_internal.h |   10 ++++++----
> >  libswscale/yuv2rgb.c          |   22 ++++++++++------------
> >  3 files changed, 31 insertions(+), 32 deletions(-)
> Looks good to me.
> I'm not that convinced if/how much faster it will be on CPUs with small
> caches, it doubles the size of the tables after all.

yep but accesses should be quite localized, color does not change so
radically from one pixel to the next normally and the areas used for
cliping should rarely be accessed

ill wait a bit more to give others also a chance to review if anyone

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120110/f0c570a8/attachment.asc>

More information about the ffmpeg-devel mailing list