[FFmpeg-devel] [PATCH]Support encoding RGB48 with libopenjpeg

Carl Eugen Hoyos cehoyos at ag.or.at
Thu Jan 12 00:04:14 CET 2012


Michael Bradshaw <mbradshaw <at> sorensonmedia.com> writes:

> +    uint16_t *frame_ptr;
> +
> +    av_assert0(numcomps == 3);
> +
> +    for (compno = 0; compno < numcomps; ++compno) {
> +        if (image->comps[compno].w > frame->linesize[0] / numcomps) {
> +            return 0;
> +        }
> +    }
> +
> +    for (compno = 0; compno < numcomps; ++compno) {
> +        frame_ptr = (uint16_t*)frame->data[0];
> 
> This line should probably be outside of the loop, seeing as frame_ptr gets
> set to the same value each loop.

Done.

> Everything else looks good though.

Tested again and patch applied.

My next patch will change the default for 16 bit 4:4:4 to RGB48 since this is
what OSX and jasper assume iiuc.
Or is there a bug and we should detect if an image is YUV or RGB?

Carl Eugen



More information about the ffmpeg-devel mailing list