[FFmpeg-devel] [PATCH] j2kdec: fix context tile memleak.

Clément Bœsch ubitux at gmail.com
Fri Jan 13 19:39:57 CET 2012


On Fri, Jan 13, 2012 at 07:32:47PM +0100, Reimar Döffinger wrote:
> On Fri, Jan 13, 2012 at 06:02:37AM +0100, Michael Niedermayer wrote:
> > On Fri, Jan 13, 2012 at 02:06:55AM +0100, Clément Bœsch wrote:
> > > ---
> > >  libavcodec/j2kdec.c |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/libavcodec/j2kdec.c b/libavcodec/j2kdec.c
> > > index 1f4cdeb..8d8d9e1 100644
> > > --- a/libavcodec/j2kdec.c
> > > +++ b/libavcodec/j2kdec.c
> > > @@ -1063,6 +1063,7 @@ static av_cold int decode_end(AVCodecContext *avctx)
> > >  
> > >      if (s->picture.data[0])
> > >          avctx->release_buffer(avctx, &s->picture);
> > > +    av_freep(&s->tile);
> > 
> > this should have been freed by cleanup(), apparently its not ...
> 
> Nothing is freed on certain errors, I expect my patch will fix it.

Yes sorry I didn't see your other patch before submitting this one;
consider it dropped.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120113/bfbf71fa/attachment.asc>


More information about the ffmpeg-devel mailing list