[FFmpeg-devel] [PATCH] mpeg12: fixed parsing in some mpeg2 streams

Michael Niedermayer michaelni at gmx.at
Sun Jan 22 07:43:21 CET 2012


On Sun, Jan 22, 2012 at 01:05:41AM +0100, Joakim Plate wrote:
> >>
> >> Anyhow, after reading the code it did seem kind of obvious, the other
> >> exit from the decoder also resets the value to 0, which makes sense -
> >> also need to find a new frame start when the end was found.
> >
> 
> Still are. When a seqendcode is discovered. All previous pictures must
> be flushed
> out, since there is no guarantee that there is anymore video data
> after that (even
> if audio keeps on going).
> 
> I'm not sure if the difference here is to make sure that happens or
> not. As long
> as all packets prior to that code exits parser without any new start
> show up, it
> should still be fine.

i suspect the patch is correct but there are more problems in there
i dont want to try to fix it without having some testcase ...
does anyone have a test file with a still picture ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120122/3d0d0ff8/attachment.asc>


More information about the ffmpeg-devel mailing list