[FFmpeg-devel] FRAPS skip frame handling

[Reimar Döffinger]

On Sun, Jan 22, 2012 at 05:21:52PM +0100, Michael Niedermayer wrote:
> On Sun, Jan 22, 2012 at 05:07:18PM +0100, Reimar Döffinger wrote:
> > On Sun, Jan 22, 2012 at 05:01:23PM +0100, Michael Niedermayer wrote:
> > > > //XXX/FIXME this is a temporary hack until all encoders output pts
> > > > and since it does not have enough information gets it wrong.
> > > > The real WTF is that this hack is run without printing the slightest
> > > > message. Would have saved me about an hour time if someone had
> > > > simply made that hack say that the encoder is broken.
> > > 
> > > Is this a regression ?
> > 
> > I don't think so, see my other patch, fixing it will change insane
> > amounts of FATE test results, so I don't think it has ever worked
> > unless it was "smuggled in" at some point.
> 
> if its not a regression then maybe we should wait until after 0.10
> with fixing it ?
> iam a bit afraid that major changes to timestamp handling might break
> things

I you intend to do the release soonish it doesn't really matter much.
But otherwise I consider the fact that (despite it appearing otherwise)
do not have any tests whatsoever concerning time stamps a very serious
issue.