[FFmpeg-devel] [PATCH] pthreads: Generic progress lubrication support.
michaelni at gmx.at
Mon Jan 23 22:40:01 CET 2012
On Mon, Jan 23, 2012 at 10:13:01PM +0100, Reimar Döffinger wrote:
> On Mon, Jan 23, 2012 at 09:34:32PM +0100, Michael Niedermayer wrote:
> > also i think whoever wants to 50x duplicate the progress update in
> > every decoder could just add this code to his local tree and once he
> > is done with the cleanup we can merge it
> > I dont see much sense in this being in main git before we have some
> > volunteer to actually do anything about these warnings.
> And I don't see people having much interest in fixing stuff if we add
> more and more crap to make it half working, hide the bugs and even more
> difficult to debug but no effort to actually bug people to fix things.
and what is half working ?
> There is also the simpler alternative I had in mind originally:
> Always complain when the progress is not INT_MAX at the end, simply
> defining that to always be the final value.
I still dont understand where the point is in duplicating the progress
update in every exit path of every decoder
that is not "less buggy" that is "more fragile" because it will be
forgotten every time a new value is checked and a new return -1 is
IMHO its much better to do this update at one place instead of for
every return -1.
But maybe you meant something else and i misunderstand you ?
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel