[FFmpeg-devel] [PATCH] pthreads: Generic progress lubrication support.
Reimar.Doeffinger at gmx.de
Mon Jan 23 23:08:28 CET 2012
On 23 Jan 2012, at 22:14, Michael Niedermayer <michaelni at gmx.at> wrote:
> of course if someone finds a clean way to print this warning then its
> a different matter but as is this looks kinda risky and messy for
> just a warning
First, this started just an example that it would be possible, it was just a quicker way of describing the idea.
Second, I had not realized that your patch was only mean as a fix to forgotten busy-work (setting it on every error condition), I had assumed the issues you looked at might have been some far more tricky threading issues (I am afraid the commit message very much mislead me, too).
Lastly, I object to "just a warning". It is a development tool, to both help new developers spot and learn about issues and to discover existing code with issues, and one that as the project grows I consider overall as important as to make good use of e.g. valgrind which after all also only prints "just warnings".
Even if in this case it might make no sense after all.
More information about the ffmpeg-devel