[FFmpeg-devel] [RFC][PATCH 3/4] build: Rename --yasmexe to --yasm-prog
ubitux at gmail.com
Wed Jan 25 09:21:27 CET 2012
On Tue, Jan 24, 2012 at 11:08:51PM +0100, Alexander Strasser wrote:
> Alexander Strasser wrote:
> > Michael Niedermayer wrote:
> > > On Mon, Jan 16, 2012 at 12:48:44AM +0100, Alexander Strasser wrote:
> > > >
> > > > Signed-off-by: Alexander Strasser <eclipse7 at gmx.net>
> > > > ---
> > > > configure | 20 ++++++++++----------
> > > > 1 files changed, 10 insertions(+), 10 deletions(-)
> > >
> > > why this renaming ?
> > I thought -yasmexe looks a bit confusing and users might
> > mistake it to be only working for "yasm.exe" on windows.
> > I can understand that you rather not like this change and
> > that's fine. Therefore I put it as RFC and split it in a separate
> > commit. The diff could probably be minimized by making a copy of
> > yasm_prog variable named yasmexe. Maybe that would be a bit against
> > the configure conventions in respect to some(most?) other options.
> > I can try to make it less invasive, if anybody besides me thinks
> > --yasmexe is not a good name and for a configure option and we can
> > settle on a better one.
> > This option will be user visible and therefore I thought it ought
> > to be worth it, giving it a useful name hence it is not polite to
> > change it after it was in for a while.
> > If others agree to stay with the name --yasmexe, this patch can
> > be safely dropped.
> Michael seems to not have a strong opinion on this one.
> Does anyone else have comments on this matter?
Since we have --cc, --ld, --as, … maybe --yasm would be more appropriate,
but no strong preferences.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 490 bytes
Desc: not available
More information about the ffmpeg-devel