[FFmpeg-devel] [PATCH] wtvdec: *_to_iso8601: Behave less surprising

Michael Niedermayer michaelni at gmx.at
Sun Jul 1 03:41:46 CEST 2012

On Sun, Jul 01, 2012 at 02:55:57AM +0200, Alexander Strasser wrote:
>   Do not violate the (implicit) contract that is indicated by
> the arguments of those functions. In other words if buf_size
> is passed as zero do not try to write to the buffer's first
> element.
> ---
>    I did not check if it is actually possible at any current
> invocation places for the size of the passed buffer to be
> be zero. The places are also limited to that file as the
> functions are declared to have file scope. I just thought it
> litters up the codebase little by little to have surprising
> code like that, so I thought it is better to clean it up now.
>    I did test nothing more than compilation on my machine.
>  libavformat/wtvdec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

LGTM, iam not maintainer of wtv though

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120701/031edd96/attachment.asc>

More information about the ffmpeg-devel mailing list