[FFmpeg-devel] [PATCH 2/3] lavf/aiffdec: don't stop parsing after SSND chunk

Michael Niedermayer michaelni at gmx.at
Sun Jul 1 16:18:58 CEST 2012


On Sun, Jul 01, 2012 at 11:16:42AM +0200, Matthieu Bouron wrote:
> Some file has ID3 chunk placed after SSND.
> ---
>  libavformat/aiffdec.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c
> index 4083316..9764f82 100644
> --- a/libavformat/aiffdec.c
> +++ b/libavformat/aiffdec.c
> @@ -251,8 +251,6 @@ static int aiff_read_header(AVFormatContext *s)
>              offset = avio_rb32(pb);      /* Offset of sound data */
>              avio_rb32(pb);               /* BlockSize... don't care */
>              offset += avio_tell(pb);    /* Compute absolute data offset */
> -            if (st->codec->block_align)    /* Assume COMM already parsed */
> -                goto got_sound;
>              if (!pb->seekable) {
>                  av_log(s, AV_LOG_ERROR, "file is not seekable\n");
>                  return -1;

this will probably cause the whole file to be read in
aiff_read_header() in some cases

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120701/8b70aac4/attachment.asc>


More information about the ffmpeg-devel mailing list