[FFmpeg-devel] [PATCH] wtvdec: return error when filetime_to_iso8601/crazytime_to_iso8601 conversion fails

Michael Niedermayer michaelni at gmx.at
Mon Jul 2 04:06:41 CEST 2012


On Mon, Jul 02, 2012 at 10:28:31AM +1000, Peter Ross wrote:
> ---
> 
> Okay, lets address the root cause here.
> 
> When gmtime() fails within {filetime,crazytime}_to_iso8601 is should return an error value,
> and instruct the callee to disregard the metadata entry. gmtime errors are very very possible
> here given the difference between wtv/win32 and unix epochs.
> 
> This style of error handling was done previously for oledate_to_iso8601, but not for
> filetime/crazytime. The patch below makes it consistent.
> 
> Alexander/Michael: I wont have computer access for some time, so apply or rework how you see fit.

patch applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120702/5dd899a8/attachment.asc>


More information about the ffmpeg-devel mailing list