[FFmpeg-devel] [PATCH] Fix pkg-config detection when using a cross-prefix

Kyle Schwarz kshawkeye at gmail.com
Mon Jul 2 23:43:03 CEST 2012


On 7/2/2012 5:28 PM, Derek Buitenhuis wrote:
> On 02/07/2012 5:20 PM, Kyle Schwarz wrote:
>> Except in that case you would need to already have a hack to get around
>> FFmpeg's configure if you even wanted to compile FFmpeg. Meaning, for
>> everyone that falls under the "we need some specific pkg-config"
>> category, this patch does not effect them. For the rare case that the
>> native pkg-config will not work with the cross toolchain, another
>> pkg-config can be set.
>
> No? I most certainly HAVE NOT. I don't know what 'hacks' you speak of.

Then you wouldn't even be effected by this patch so the example you gave 
does not help. If you don't need to set any special options, then it's 
using a cross prefixed pkg-config anyway, or you didn't specify a cross 
prefix and it's using the native one. Either way, this patch does not 
effect the working pkg-configs.

>> With the current FFmpeg, you couldn't even compile if a cross prefixed
>> pkg-config is not found.
>
> It is better to fail then silently do something possibly wrong.

There is no "possible" way that this is wrong. This is how other 
packages work when a cross prefixed pkg-configs. This patch will not 
break anything.

>> Also, in the example you gave, does that mean that you have a cross
>> prefixed pkg-config built already? If so, then it would use that one by
>> default anyway. This patch is only a fallback, and does not effect
>> anything that already works.
>
> You need to read carefully. I said if it went missing for whatever reason.

If it went missing? If pkg-config went missing? What are you referring 
to missing? How would pkg-config "missing" be effected by this patch?


More information about the ffmpeg-devel mailing list