[FFmpeg-devel] [PATCH 1/5] libavutil: prefix all log messages with thread id
martin.carroll at alcatel-lucent.com
Tue Jul 3 14:42:01 CEST 2012
Nicolas, thanks for your feedback.
> declare pointers as "type *pointer"
> I see a global structure meant to be accessed from several threads and
> nothing to make a memory barrier.
Oops, my goof. My reasoning was that the code that you refer to is
called from the thread *creator*, not the threads themselves, but of
course anyone, including multiple threads, can be thread creators.
I will fix.
> Also, it seems to me that using thread-local storage for that would
> simpler and more efficient.
I default to not using thread-local storage because thread-local storage
used to be nonportable, and I have no idea how many archaic machines
ffmpeg is being built on. However, if thread-local storage is preferred
by ffmpeg folks, I will convert to that. Just let me know.
> You cannot [compare pthread IDs]
Good point. Frankly, I was unaware of the == issue because in my personal
experience I have never encountered a system for which == did not work.
> Documentation on the arguments, especially "fcn", is sorely missing.
I'm by no means the only violator in that regard, but I will fix.
More information about the ffmpeg-devel