[FFmpeg-devel] [PATCH 1/2] tool/bisect: add some magic to make the bisect tool be useable when its not part of a checkout
michaelni at gmx.at
Sat Jul 7 17:33:05 CEST 2012
On Tue, Jul 03, 2012 at 10:00:41PM +0200, Alexander Strasser wrote:
> Hi Michael,
> Michael Niedermayer wrote:
> > diff --git a/tools/bisect b/tools/bisect
> > index de43f68..cdf3226 100755
> > --- a/tools/bisect
> > +++ b/tools/bisect
> > @@ -2,6 +2,23 @@
> > set -e
> > +if test "bisect" = "`basename $0`" ; then
> > + echo WARNING, trying to execute tools/bisect directly this cannot work as
> > + echo the script itself would not be available in older checkouts
> > + echo please use tools/bisec
> > + git show master:tools/bisect > tools/bisec
> > + chmod u+x tools/bisec
> > + exit 1
> > +fi
> The distinction bisect/bisec seems a bit too subtle too me. Especially as
> the latter looks like a typo at first.
> Would it be a solution to rename the checked in file into bisect-create?
> In that case the warning message could be replaced by
> "Created tools/bisect"
> While thinking more about it naming the created file bisect could cause
> trouble for the few revisions where tools/bisect is part of the source.
> Maybe tools/ffbisect?
changes done and applied
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The worst form of inequality is to try to make unequal things equal.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel