[FFmpeg-devel] [PATCH] latm: fix initialization on some streams when no extradata is available

[Michael Niedermayer]

On Thu, Jun 21, 2012 at 12:25:31PM +0200, Reimar Döffinger wrote:
> On Thu, Jun 21, 2012 at 11:57:59AM +0200, Hendrik Leppkes wrote:
> > On Thu, Jun 21, 2012 at 11:48 AM, Reimar Döffinger <Reimar.Doeffinger at gmx.de
> > > wrote:
> > 
> > >
> > > Shouldn't rather all the stuff be set up in the init function?
> > >
> > 
> > The problem starts when there is not enough information for the init
> > function to work completely, and instead the full configuration is only
> > available when the first latm frame is decoded.
> > Most of the time, i know sample rate and channels before opening the codec,
> > so i set them on the AVCodecContext, and the aac init function sets them on
> > its internal context, but the full latm initialization is not done because
> > there is no extradata. Now when the first frame is decoded, the existing
> > checks don't catch because sample rate and channel config did not change,
> > but the full latm init is still missing.
> 
> A possible option going by that description might be to set sample rate
> etc. to 0 on init?
> 
> > I'm open to other ideas to solve the problem, but i usually prefer rather
> > simple changes, even if it means that one log message comes out wrong. ;)
> 
> You could just not print or print a different message when the codec
> is not yet initialized at that point I'd say...
> A confusing log message isn't a good idea just to save around one line
> of code IMO.

ive fixed the message text

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120708/71f203ec/attachment.asc>