[FFmpeg-devel] [PATCH] exr: add CODEC_CAP_DR1

Paul B Mahol onemda at gmail.com
Sun Jul 8 04:15:06 CEST 2012


On 7/8/12, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Jul 07, 2012 at 09:00:36PM +0000, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  libavcodec/exr.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/libavcodec/exr.c b/libavcodec/exr.c
>> index a95423f..5ff2c6f 100644
>> --- a/libavcodec/exr.c
>> +++ b/libavcodec/exr.c
>> @@ -491,5 +491,6 @@ AVCodec ff_exr_decoder = {
>>      .init               = decode_init,
>>      .close              = decode_end,
>>      .decode             = decode_frame,
>> +    .capabilities       = CODEC_CAP_DR1,
>>      .long_name          = NULL_IF_CONFIG_SMALL("OpenEXR image"),
>>  };
>
> probably ok
> but i would suggest to test all the dr1 additions with mplayer as
> mplayer historically had the tendency to be more DR1 bug sensitive

Mplayer have own list of codecs where dr1 is not enabled
because mplayer implementation of dr1 have many limitations
(worst one being: dr1 is disabled with multithreading).

So enabling DR1 for yop or dirac (which is perfectly fine) will break
decoding with mplayer and I did not sent patches for them even
i could because there is nothing wrong on our side.

Also it appears dr1 is not used for audio codecs at all.


More information about the ffmpeg-devel mailing list