[FFmpeg-devel] [PATCH] lavfi: add init2 callback

Stefano Sabatini stefasab at gmail.com
Tue Jul 10 01:34:48 CEST 2012


On date Sunday 2012-07-08 16:52:48 +0200, Nicolas George encoded:
> Le nonidi 19 messidor, an CCXX, Stefano Sabatini a écrit :
> > Honestly I'd find this more hackish/less usable.
> 
> I completely agree it is more hackish, but it has one huge advantage: it
> does not show in the public interface.
> 
> > I propose to keep my hack, and then deprecate the init_opaque
> > interface when we'll have a better solution, for the moment I prefer
> > the lazy minimum-effort solution which works and seems not too
> > occlusive and allows easy backward compatibility. 
> 
> I believe my hack abusing the function call conventions is more lazy minimum
> effort than yours, see attached patch.
> 
> But please go ahead with whatever solution you prefer. Just be sure, if you
> decide to change something in the headers, to clearly state that we may
> remove it at any time without notice.

OK thanks, we'll deprecate the interface when/if we'll have a better
solution, no need to bother users even more than we're already doing
by having them to deal with spectral interfaces.

Pushed my variant.
-- 
FFmpeg = Fantastic and Frightening Most Perfectionist Explosive God


More information about the ffmpeg-devel mailing list