[FFmpeg-devel] [PATCH 1/2] avcodec: add decode_error field to AVFrame

Marton Balint cus at passwd.hu
Tue Jul 10 23:57:59 CEST 2012



On Tue, 10 Jul 2012, Reimar Döffinger wrote:

> On Sun, Jul 08, 2012 at 06:12:08PM +0200, Marton Balint wrote:
>> +    /**
>> +     * decode error flag of the frame, set to a nonzero codec-specific error
>> +     * code if the decoder produced a frame, but there were errors during
>> +     * the decoding.
>
> I don't like the codec specific error. I'd very much prefer this to be a
> bit field, with at least some things pre-defined.
> I don't mind a part being reserved for codec-specific stuff though.

I gave this a thought before sending the patch, but I could not think of 
too many generic decode errors, do you have some ideas?

And what would be your goal with the generic errors? Indicate the reason 
of the decode error as precisely as possible? In that case probably the 
generic errors won't be specific enough... Or to indicate the "quality" of 
the decoded frame (e.g. it is probably complete garbage, or it is roughly 
the same as it would be without the decode error, etc). That is probably 
not easy (sometimes not even possible) to determine...

Personally I don't like the bitfield idea, if we are to provide a 
generic and a specific error as well, we probably should add both a 
generic and a specific error field to AVframe.

Regards,
Marton

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


More information about the ffmpeg-devel mailing list