[FFmpeg-devel] [PATCH 1/3] oggdec: add support for Opus codec.

Nicolas George nicolas.george at normalesup.org
Wed Jul 11 00:57:05 CEST 2012

Le tridi 23 messidor, an CCXX, Reimar Döffinger a écrit :
> sizeof(*priv) I'd suggest.

Good idea, changed.

> using AV_RL8 seems a bit like overkill.

There is nothing overkill in AV_RL8: it is a trivial macro that just
dereferences the pointer casted to uint8_t. I used it rather than a simple
dereference for cosmetic consistency reasons.

> Why decrement? Can it become > 1 somehow?

Not currently, but I have seen Ogg encapsulations with more than one comment
packet, so it seemed like a more idiomatic way of writing it.

> Is there any system to this? Looks rather ugly...

The spec has a rather long table for the various values of toc_config; the
tables includes the frame_size and other pieces of information that are not
relevant for a demuxer; I expressed the table as compactly as possible.

> The & 3 could be factored out I'd say.

Not sure if it really makes things really clearer, but changed.

> I don't think comment-out code should be there.

It will go away once the problem about pre_skip is settled.

Thanks for the review.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120711/ccc6acaa/attachment.asc>

More information about the ffmpeg-devel mailing list