[FFmpeg-devel] [PATCH] mss1: improve check if decoded pivot is invalid

Michael Niedermayer michaelni at gmx.at
Sun Jul 15 03:33:23 CEST 2012

On Sun, Jul 15, 2012 at 12:50:50AM +0000, Paul B Mahol wrote:
> On 7/15/12, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> > On 14/07/2012 8:39 PM, Paul B Mahol wrote:
> >>> Can you add an actual explanation of what you fixed
> >>> > into the commit message?
> >> You mean bug report or explanation what that C code does?
> >
> > In what way does it 'improve' it? What does it fix? You
> > don't even have a bug tracker ID. This commit is completely
> > missing any useful information at all.
> Get over it. I had enough of such hypocrite reviews with Libav.

I think derek just wants a more elaborate commit message that explains
with more detail what this fixes and why and how. 

Maybe something like:

the pivot has to lie between 0 and base thus a check of ==base is
insufficient. Thus replace it by a proper check

IMHO adding that extra line is not a bad idea, though its no major
thing to me if that line is there or not. Its a major thing to others
it seems ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120715/e3e296de/attachment.asc>

More information about the ffmpeg-devel mailing list