[FFmpeg-devel] [PATCH 4/4] ffmpeg: probe buffersinks once more after EOF.

Nicolas George nicolas.george at normalesup.org
Wed Jul 18 00:10:29 CEST 2012

Le decadi 30 messidor, an CCXX, Stefano Sabatini a écrit :
> I suggest:
> Reap buffers stored in the buffer sinks even when
> the avfilter_graph_request_oldest() loop only returns EOF.

Locally changed.

> > +    unsigned nb_success = 1, av_uninit(nb_eof);
>                                 ^^^^^^^^^^^^^^^^^
> How is this related?

It silences a warning my change triggers.

More specifically (you can skip if you are not interested): the "break" at
its new place is after the place where nb_eof is inited, and gcc does not
realize that, due to nb_success being initially true, the loop always run at
least once. Thus a warning about nb_eof being used uninitialized after the

> Looks good otherwise.

Thanks. I'll let it some more time and push if no one objects.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120718/38de7b07/attachment.asc>

More information about the ffmpeg-devel mailing list