[FFmpeg-devel] [PATCH] lavd/caca: create display *after* checking dither options

Stefano Sabatini stefasab at gmail.com
Sun Jul 22 10:36:39 CEST 2012


On date Saturday 2012-07-21 18:46:14 +0000, Paul B Mahol encoded:
> On 7/21/12, Stefano Sabatini <stefasab at gmail.com> wrote:
> > On date Saturday 2012-07-21 16:17:31 +0000, Paul B Mahol encoded:
> >> On 7/21/12, Stefano Sabatini <stefasab at gmail.com> wrote:
> >> > Avoid fastidious creation and immediate destroy of the display in case
> >> > one of the dither options fails to be set.
> >> >
> >> > Also add NULL checks in write_trailer(), which are now necessary since
> >> > the function can be called when not all the components have been
> >> > initialized.
> >> > ---
> >> >  libavdevice/caca.c |   38 +++++++++++++++++++++-----------------
> >> >  1 files changed, 21 insertions(+), 17 deletions(-)
> >> >
> 
> lgtm

Applied. Thanks for all the reviews.
-- 
FFmpeg = Fast & Fast Murdering Perennial Elitarian Gymnast


More information about the ffmpeg-devel mailing list