[FFmpeg-devel] [RFC] [PATCH] iff: ANIM suppport

Don Moir donmoir at comcast.net
Sun Jul 22 14:20:01 CEST 2012


----- Original Message ----- 
From: "Don Moir" <donmoir at comcast.net>
To: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
Sent: Sunday, July 22, 2012 7:55 AM
Subject: Re: [FFmpeg-devel] [RFC] [PATCH] iff: ANIM suppport


>> ----- Original Message ----- 
>> From: "Carl Eugen Hoyos" <cehoyos at ag.or.at>
>> To: <ffmpeg-devel at ffmpeg.org>
>> Sent: Sunday, July 22, 2012 7:18 AM
>> Subject: Re: [FFmpeg-devel] [RFC] [PATCH] iff: ANIM suppport
>>
>>
>>> Peter Ross <pross <at> xvid.org> writes:
>>>
>>>> Gents, is there a sample file available that demonstrates the issue?
>>>
>>
>> I think all the samples at this link produce the problem but try 
>> MARBLES.IFF
>>
>> http://www.fileformat.info/format/iff/sample/index.htm
>>
>>
>>>> Carl, this patch is no good. The decoder already supports some 
>>>> transparency.
>>>> It sets the alpha bits to 0xFF for all standard pixels, and clears them 
>>>> to
>>>> 0x00 for transparent pixels. I dont know what the problem is.
>>>
>>
>> I was about to test that patch and will go ahead and test it but you say 
>> no good. It will be easy for me to test anything else you might come up 
>> with
>>
>
> That patch does work as expected since it just means there will be no 
> alpha but it could possibly break a file that has real alpha in it - don't 
> know.
>
> Not sure how you will be testing this case, but don't come to the wrong 
> conclusion by using an app that doesn't do transparency.

The MARBLES.IFF file seemed ok to me at first with that patch but the 
FLAG_B24.IFF display is blurred. Without that patch and me ignoring 
transparency, they both look fine. The blurring may be an swscale problem.

Let me know and I will post a bug report if needed. 



More information about the ffmpeg-devel mailing list